fix: return empty array encoding for parse_array#12541
Closed
Bilogweb3 wants to merge 1 commit intofoundry-rs:masterfrom
Closed
fix: return empty array encoding for parse_array#12541Bilogweb3 wants to merge 1 commit intofoundry-rs:masterfrom
Bilogweb3 wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
Bilogweb3
requested review from
DaniPopes,
grandizzy and
mattsse
as code owners
Bilogweb3
requested review from
0xrusowsky,
onbjerg and
zerosnacks
as code owners
Contributor
|
can you add a test? |
Contributor
Author
|
@0xrusowsky empty string and empty array have identical ABI encoding, so tests pass with both old and new code. The fix is still correct though:
If you still want me to add tests I can do that. |
Member
|
doesn't matter, it's the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parse_array receives no values, it now returns a properly typed DynSolValue::Array instead of a String. While both have identical ABI encoding, this fixes semantic correctness and makes the code match its comment and function name.